[compiler] Type ref prop as a ref
#29834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
added a commit
that referenced
this pull request
Jun 10, 2024
ghstack-source-id: a0c061eac26f7fe54c0c902840c9f44f656eb504 Pull Request resolved: #29834
facebook-github-bot
added
CLA Signed
React Core Team
[ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jun 10, 2024
ghstack-source-id: 5a8395225783df9a2d29892ee39c31af0fc5742c Pull Request resolved: #29834
poteto
approved these changes
Jun 10, 2024
|
Comparing: a532d91...9f141fa Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Adds a shape type for component props, which has one defined property: "ref". This means that if the ref property exists, we can type usage of `props.ref` (or via destructuring) the same as the result of `useRef()` and infer downstream usage similarly. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jun 10, 2024
Adds a shape type for component props, which has one defined property: "ref". This means that if the ref property exists, we can type usage of `props.ref` (or via destructuring) the same as the result of `useRef()` and infer downstream usage similarly. ghstack-source-id: 76cd07c5dfeea2a4aafe141912663b097308fd73 Pull Request resolved: #29834
josephsavona
added a commit
that referenced
this pull request
Jun 10, 2024
Adds a shape type for component props, which has one defined property: "ref". This means that if the ref property exists, we can type usage of `props.ref` (or via destructuring) the same as the result of `useRef()` and infer downstream usage similarly. ghstack-source-id: 76cd07c5dfeea2a4aafe141912663b097308fd73 Pull Request resolved: #29834
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
refprop as a ref #29834Adds a shape type for component props, which has one defined property: "ref". This means that if the ref property exists, we can type usage of
props.ref(or via destructuring) the same as the result ofuseRef()and infer downstream usage similarly.