[compiler] Provide support for custom fbt-like macro functions #29893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: 6c05e7aa20ba8cbd19c932b052ce4c744ed5f07b Pull Request resolved: #29893
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
commented
Jun 14, 2024
| const $ = _c(2); | ||
| const theme = useTheme(); | ||
|
|
||
| const t0 = cx({ |
There was a problem hiding this comment.
i verified that without the change (and without the @customMacros(cx) pragma) this fixture assigns cx to a local
…ions" [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: e3c6455ac2240914c3f25f3266a0cbb4a63971b5 Pull Request resolved: #29893
|
Comparing: 2ba462b...8d49249 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: e3c6455ac2240914c3f25f3266a0cbb4a63971b5 Pull Request resolved: #29893
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):