Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler][hir] Correctly remove non-existent terminal preds when pruning labels #30076

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[compiler][hir] Correctly remove non-existent terminal preds when pruning labels #30076

merged 3 commits into from
Jun 25, 2024

Commits on Jun 24, 2024

  1. [compiler][hir] Correctly remove non-existent terminal preds when pru… 

    …ning labels

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f8026d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Update on "[compiler][hir] Correctly remove non-existent terminal pre… 

    …ds when pruning labels"

Missed this initially in `pruneUnusedLabelsHIR`. It wasn't an active bug as `preds` wasn't referenced by later passes, until #30079

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b1db59f View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler][hir] Correctly remove non-existent terminal pre… 

    …ds when pruning labels"

Missed this initially in `pruneUnusedLabelsHIR`. It wasn't an active bug as `preds` wasn't referenced by later passes, until #30079

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    01693b6 View commit details
    Browse the repository at this point in the history