Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Always error on async reassignments #30111

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

mvitousek
Copy link
Contributor

@mvitousek mvitousek commented Jun 26, 2024

Stack from ghstack (oldest at bottom):

Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

[ghstack-poisoned]
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 0:10am

mvitousek added a commit that referenced this pull request Jun 26, 2024
Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

ghstack-source-id: 5cf4b1db7ffff2db962d9b1fc3e9b37e10e3dff2
Pull Request resolved: #30111
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss

@react-sizebot
Copy link

Comparing: 00775d9...d8fba52

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.10 kB 597.10 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.44 kB 571.44 kB = 101.24 kB 101.24 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against d8fba52

Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jun 27, 2024
Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

ghstack-source-id: 9f15cf0f144c0badd6009ceb51df43a50399d82b
Pull Request resolved: #30111
@mvitousek mvitousek merged commit 5b63533 into gh/mvitousek/1/base Jun 27, 2024
17 of 22 checks passed
@mvitousek mvitousek deleted the gh/mvitousek/1/head branch June 27, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants