Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-refresh-webpack-plugin in Flight fixture #30156

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

unstubbable
Copy link
Contributor

This fixes the following error when starting the Flight fixture with yarn dev:

[1] ERROR in ./src/cjs/Counter3.js 1:0
[1] Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (1:0)
[1] File was processed with these loaders:
[1]  * ./node_modules/@pmmmwh/react-refresh-webpack-plugin/loader/index.js
[1]  * ./node_modules/babel-loader/lib/index.js
[1]  * ./node_modules/source-map-loader/dist/cjs.js
[1] You may need an additional loader to handle the result of these loaders.
[1] > import * as __react_refresh_runtime__ from '/Users/hendrik/code/react/fixtures/flight/node_modules/react-refresh/runtime.js';
[1] | __webpack_require__.$Refresh$.runtime = __react_refresh_runtime__;

It avoids needing to run FAST_REFRESH=false yarn dev as a workaround.

This fixes the following error when starting the Flight fixture with
`yarn dev`:

```
[1] ERROR in ./src/cjs/Counter3.js 1:0
[1] Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (1:0)
[1] File was processed with these loaders:
[1]  * ./node_modules/@pmmmwh/react-refresh-webpack-plugin/loader/index.js
[1]  * ./node_modules/babel-loader/lib/index.js
[1]  * ./node_modules/source-map-loader/dist/cjs.js
[1] You may need an additional loader to handle the result of these loaders.
[1] > import * as __react_refresh_runtime__ from '/Users/hendrik/code/react/fixtures/flight/node_modules/react-refresh/runtime.js';
[1] | __webpack_require__.$Refresh$.runtime = __react_refresh_runtime__;
```

It avoids needing to run `FAST_REFRESH=false yarn dev` as a workaround.
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:55am

@react-sizebot
Copy link

Comparing: d6b1c48...ec26dd9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against ec26dd9

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants