Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format DOM Nesting Warning as Diff View + An Additional Log for Stack Trace #30302

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Format DOM Nesting Warning as Diff View + An Additional Log for Stack Trace #30302

merged 5 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. Use owner stacks in nesting warnings 

    Use a second long to communicate the location of the parent.
    @sebmarkbage
    sebmarkbage committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cd6656b View commit details
    Browse the repository at this point in the history

  2. Build a "hydration diff" highlighting the two nodes involved

    @sebmarkbage
    sebmarkbage committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c07aaee View commit details
    Browse the repository at this point in the history

  3. Let text and fragment nodes inherit their parent as their owner 

    They don't have their own owner so to get some owner stacks we can use
the parent as the owner.

Effectively this also means using the parent's debugTask for native stacks.

This ensures that createTask is active when a HostText node runs its validation.
    @sebmarkbage
    sebmarkbage committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b409317 View commit details
    Browse the repository at this point in the history

  4. Use > as a marker for attention 

    Co-authored-by: tjallingt <[email protected]>
    @sebmarkbage @tjallingt
    sebmarkbage and tjallingt committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5dee34a View commit details
    Browse the repository at this point in the history

  5. Outdated comments

    @sebmarkbage
    sebmarkbage committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a14245d View commit details
    Browse the repository at this point in the history