Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add devtools regression workflow #30406

Merged
merged 11 commits into from
Jul 25, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 19, 2024

Stack from ghstack (oldest at bottom):

More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:17pm

poteto added a commit that referenced this pull request Jul 19, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: c60f15ffbcd5bc626b5fc499289783e4c15c3505
Pull Request resolved: #30406
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 19, 2024
@react-sizebot
Copy link

react-sizebot commented Jul 19, 2024

Comparing: 0a76aec...9a7d2f4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.39 kB 501.39 kB = 89.96 kB 89.96 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.21 kB 506.21 kB = 90.66 kB 90.66 kB
facebook-www/ReactDOM-prod.classic.js = 598.83 kB 598.83 kB = 105.76 kB 105.76 kB
facebook-www/ReactDOM-prod.modern.js = 574.94 kB 574.94 kB = 101.99 kB 101.99 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 97bc220

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 19, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: e76d8245bc0171eee01e5a20be085f2391d6fe18
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 19, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: d33946f7f68c2ae4df7ec97d471c1ae92d2df418
Pull Request resolved: #30406
@hoxyq
Copy link
Contributor

hoxyq commented Jul 19, 2024

I have no idea why e2e tests are failing for React 16, because they were passing on main yesterday and there were no changes to React / React DevTools since then. Maybe there is something related to the environment, is the version of Node the same?

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 19, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 90332d0bae0b411dc5bd06cb4a95b9b8f2bb44a2
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 811e30db3c2e04035b8b2eb4e52cdb6567cc1f0f
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 2e9b440354f3366cd43b1374b16918a40273bd76
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 2bf2e60b7cbf2048e91eb45a44d85c4cd6f09fa0
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 811e30db3c2e04035b8b2eb4e52cdb6567cc1f0f
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 25, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 5e3c1904c5818f219dc5f8098208e14e2676a68d
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 25, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 32fcfdc15de06d442987a9e26d1f5be3628b776c
Pull Request resolved: #30406
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 25, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: cb3456c602bf0bd3cb6ef5862ecac6b8d6e99e0b
Pull Request resolved: #30406
@poteto
Copy link
Member Author

poteto commented Jul 25, 2024

@poteto poteto requested a review from hoxyq July 25, 2024 21:25
@poteto poteto merged commit 97bc220 into gh/poteto/34/base Jul 25, 2024
190 checks passed
poteto added a commit that referenced this pull request Jul 25, 2024
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: cb3456c602bf0bd3cb6ef5862ecac6b8d6e99e0b
Pull Request resolved: #30406
@poteto poteto deleted the gh/poteto/34/head branch July 25, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants