[compiler] Repro for interaction b/w outlining and idx #30435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jul 23, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: #30435
facebook-github-bot
added
CLA Signed
React Core Team
mofeiZ
approved these changes
Jul 23, 2024
mofeiZ
reviewed
Jul 23, 2024
| @@ -0,0 +1,12 @@ | |||
| import idx from 'idx'; | |||
There was a problem hiding this comment.
Nit: could we rename this fixture to error.bug-idx-outlining to differentiate between bugs and expected errors?
There was a problem hiding this comment.
oops, landed too quickly! i'm gonna try and fix this bug so hopefully I'll be able to rename it then
poteto
added a commit
that referenced
this pull request
Jul 23, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: #30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
babel-plugin-idx enforces that its 2nd argument is an arrow function, so outlining needs to skip over lambdas that are args to idx. This PR adds a small repro highlighting the issue. ghstack-source-id: b4627ec552056f33090e2f7bc0536a6006d79d18 Pull Request resolved: facebook#30435
This was referenced Jul 25, 2024
mvitousek
added a commit
that referenced
this pull request
Aug 2, 2024
Summary: Fixes issue documented by #30435. We change the pipeline order so that outlining comes after tracking macro operands, and any function that is referenced in a macro will now not be outlined. [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Aug 2, 2024
…being outlined" Summary: Fixes issue documented by #30435. We change the pipeline order so that outlining comes after tracking macro operands, and any function that is referenced in a macro will now not be outlined. [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Aug 2, 2024
Summary: Fixes issue documented by #30435. We change the pipeline order so that outlining comes after tracking macro operands, and any function that is referenced in a macro will now not be outlined. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
babel-plugin-idx enforces that its 2nd argument is an arrow function, so
outlining needs to skip over lambdas that are args to idx. This PR adds
a small repro highlighting the issue.