Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Include environment name both in the virtual URL and findSourceMapURL #30452

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[Flight] Include environment name both in the virtual URL and findSourceMapURL #30452

merged 1 commit into from
Jul 25, 2024

Conversation

sebmarkbage
Copy link
Collaborator

This way you can use the environment to know where to look for the source map in case you have multiple server environments.

This becomes part of the public protocol since it's part of what you'll parse out of the rsc://React/ prefixed URLs inside of captureOwnerStack.

@sebmarkbage sebmarkbage requested a review from eps1lon July 24, 2024 22:58
@vercel Vercel
Copy link

vercel bot commented Jul 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 3:06pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 24, 2024
sebmarkbage
sebmarkbage commented Jul 24, 2024
View reviewed changes
packages/react-client/src/__tests__/ReactFlight-test.js
return (
<ClientErrorBoundary>
<ServerComponent />
</ClientErrorBoundary>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this executes on the server it needs to use ReactServer.

It didn't have the correct owner before.

@react-sizebot
Copy link

react-sizebot commented Jul 24, 2024 •
edited
Loading

Comparing: 4b62400...63f09c4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.44 kB 501.44 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.26 kB 506.26 kB = 90.68 kB 90.68 kB
facebook-www/ReactDOM-prod.classic.js = 599.78 kB 599.78 kB = 105.88 kB 105.88 kB
facebook-www/ReactDOM-prod.modern.js = 575.83 kB 575.83 kB = 102.15 kB 102.15 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +1.17% 79.65 kB 80.58 kB +1.09% 15.09 kB 15.25 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +1.15% 81.08 kB 82.01 kB +1.08% 14.84 kB 15.01 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +1.14% 77.28 kB 78.16 kB +1.07% 14.56 kB 14.71 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +1.13% 82.28 kB 83.21 kB +1.16% 15.58 kB 15.76 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +1.11% 79.14 kB 80.02 kB +1.06% 14.97 kB 15.13 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +1.11% 83.69 kB 84.62 kB +1.11% 15.90 kB 16.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +1.10% 84.50 kB 85.43 kB +1.13% 16.07 kB 16.25 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +1.09% 85.87 kB 86.80 kB +1.02% 16.35 kB 16.52 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +1.09% 85.88 kB 86.81 kB +1.02% 16.33 kB 16.50 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +1.07% 87.61 kB 88.54 kB +1.08% 16.43 kB 16.61 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +1.06% 88.40 kB 89.33 kB +1.07% 16.61 kB 16.79 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.73% 110.24 kB 111.04 kB +0.85% 24.70 kB 24.91 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js +0.59% 77.41 kB 77.87 kB +0.56% 14.19 kB 14.27 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.59% 77.41 kB 77.87 kB +0.56% 14.19 kB 14.27 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.59% 77.41 kB 77.87 kB +0.56% 14.19 kB 14.27 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.57% 80.97 kB 81.43 kB +0.53% 15.35 kB 15.43 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.57% 80.97 kB 81.43 kB +0.53% 15.35 kB 15.43 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.57% 80.97 kB 81.43 kB +0.53% 15.35 kB 15.43 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.56% 82.33 kB 82.79 kB +0.53% 15.64 kB 15.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.56% 82.33 kB 82.79 kB +0.53% 15.64 kB 15.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.56% 82.33 kB 82.79 kB +0.53% 15.64 kB 15.72 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.56% 82.35 kB 82.81 kB +0.57% 15.62 kB 15.71 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.56% 82.35 kB 82.81 kB +0.57% 15.62 kB 15.71 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.56% 82.35 kB 82.81 kB +0.57% 15.62 kB 15.71 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.55% 73.71 kB 74.12 kB +0.69% 13.84 kB 13.94 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.55% 73.71 kB 74.12 kB +0.69% 13.84 kB 13.94 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.55% 73.71 kB 74.12 kB +0.69% 13.84 kB 13.94 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.55% 84.07 kB 84.53 kB +0.47% 15.72 kB 15.80 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.55% 84.07 kB 84.53 kB +0.47% 15.72 kB 15.80 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.55% 84.07 kB 84.53 kB +0.47% 15.72 kB 15.80 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.54% 84.86 kB 85.32 kB +0.51% 15.90 kB 15.98 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.54% 84.86 kB 85.32 kB +0.51% 15.90 kB 15.98 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.54% 84.86 kB 85.32 kB +0.51% 15.90 kB 15.98 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.53% 75.57 kB 75.97 kB +0.58% 14.25 kB 14.33 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.53% 75.57 kB 75.97 kB +0.58% 14.25 kB 14.33 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.53% 75.57 kB 75.97 kB +0.58% 14.25 kB 14.33 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.53% 76.02 kB 76.43 kB +0.54% 14.37 kB 14.44 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.53% 76.02 kB 76.43 kB +0.54% 14.37 kB 14.44 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.53% 76.02 kB 76.43 kB +0.54% 14.37 kB 14.44 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.51% 78.65 kB 79.05 kB +0.53% 14.88 kB 14.96 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.51% 78.65 kB 79.05 kB +0.53% 14.88 kB 14.96 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.51% 78.65 kB 79.05 kB +0.53% 14.88 kB 14.96 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.50% 80.06 kB 80.47 kB +0.50% 15.19 kB 15.27 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.50% 80.06 kB 80.47 kB +0.50% 15.19 kB 15.27 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.50% 80.06 kB 80.47 kB +0.50% 15.19 kB 15.27 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.27% 104.15 kB 104.43 kB +0.29% 23.37 kB 23.43 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.27% 104.15 kB 104.43 kB +0.29% 23.37 kB 23.43 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.27% 104.15 kB 104.43 kB +0.29% 23.37 kB 23.43 kB
oss-experimental/react-html/cjs/react-html.react-server.development.js +0.23% 488.78 kB 489.90 kB +0.22% 88.14 kB 88.34 kB

Generated by 🚫 dangerJS against 3ff4cbb

@sebmarkbage
Include environment name both in the virtual URL and findSourceMapURL
3ff4cbb 
This way you can use the environment to know where to look for the source
map in case you have multiple server environments.
@sebmarkbage sebmarkbage merged commit e5d2245 into facebook:main Jul 25, 2024
187 checks passed
@eps1lon eps1lon mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @eps1lon @facebook-github-bot