[compiler] Rewrite useContext callee #30612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsathya
added a commit
that referenced
this pull request
Aug 6, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: 60120858972dacc54bfc55daaadd0924a10f2cba Pull Request resolved: #30612
facebook-github-bot
added
the
React Core Team
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Aug 6, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: c305c4dffd4a9b794320ded734520ff35ade05db Pull Request resolved: #30612
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Aug 6, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: c305c4dffd4a9b794320ded734520ff35ade05db Pull Request resolved: #30612
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Aug 6, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: c305c4dffd4a9b794320ded734520ff35ade05db Pull Request resolved: #30612
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Aug 6, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: 0a4a3b6bbbbd4f75591f7a99a35ca23e56f6ba08 Pull Request resolved: #30612
kassens
requested changes
Aug 7, 2024
| @@ -15,7 +15,8 @@ function App() { | |||
| ## Code | |||
|
|
|||
| ```javascript | |||
| import { c as _c } from "react/compiler-runtime"; // @enableLowerContextAccess | |||
| import { useContext_withSelector } from "react-compiler-runtime"; | |||
| import { c as _c } from "react/compiler-runtime"; // @lowerContextAccess | |||
| function App() { | |||
| const $ = _c(3); | |||
| const context = useContext(MyContext); | |||
There was a problem hiding this comment.
name doesn't match the name of the generated import
There was a problem hiding this comment.
yeah because it's not lowered here -- note the todo in the filename
There was a problem hiding this comment.
i need to keep some state to check if we lower or not and propagate to the result, not sure if it's worth doing? is it an issue to have the unused imports?
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Aug 7, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: 00e161b988c8f8a1cf96efff8095f050cb534cc1 Pull Request resolved: #30612
josephsavona
approved these changes
Aug 8, 2024
gsathya
added a commit
that referenced
this pull request
Aug 8, 2024
If a value is specified for the LowerContextAccess environment config, we rewrite the callee from 'useContext' to the specificed value. This will allow us run an experiment internally. ghstack-source-id: 00e161b988c8f8a1cf96efff8095f050cb534cc1 Pull Request resolved: #30612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
If a value is specified for the LowerContextAccess environment config,
we rewrite the callee from 'useContext' to the specificed value.
This will allow us run an experiment internally.