Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Unmount by walking previous nodes no longer in the new tree #30644

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[DevTools] Unmount by walking previous nodes no longer in the new tree #30644

merged 2 commits into from
Aug 12, 2024

Commits on Aug 9, 2024

  1. Unmount by walking previous nodes no longer in the new tree

    @sebmarkbage
    sebmarkbage committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    979e02c View commit details
    Browse the repository at this point in the history

  2. Untrack Fibers immediately 

    This scheduling thing shouldn't be needed because there's nothing
else that manipulates the set. In fact, this was creating a problem now
because we used to always add stuff to the set before commit root and then
flush them synchronously in commit root anyway.

At some point flushPendingErrorsAndWarningsAfterDelay stopped untracking
IDs and so the reason for this queuing dosen't seem to apply.
    @sebmarkbage
    sebmarkbage committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    216c943 View commit details
    Browse the repository at this point in the history