-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin-react-hooks): support flat config #30774
base: main
Are you sure you want to change the base?
Conversation
Hi @michaelfaith! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Hi, any advance with this? |
Not sure. Waiting on someone from the team to look at it. |
Might have to direct message Mark at this point |
@eps1lon with the release of 5.0 and eslint v9 support 🥳 , would it be possible to push this forward now for flat config support? Any feedback would be greatly appreciated. |
Can you rebase? Seems like CI missed this. |
0030784
to
4c484ec
Compare
This change adds support for the new flat config format. In order to import from json, I had to add the rollup json plugin to the rollup build script. I also updated the README to include usage examples. Example usage: ```js export default [ { files: ['**/*.{js,jsx}'], languageOptions: { ecmaVersion: 2020, globals: globals.browser, parserOptions: { ecmaVersion: 'latest', ecmaFeatures: {jsx: true}, sourceType: 'module', }, }, settings: {react: {version: '18.3'}}, ...reactHooks.flatConfigs.recommended, }, ]; ```
4c484ec
to
b965c61
Compare
Done. And made the adjustment to the index, to remove the new dependency on the rollup plugin. |
The support for flat config is backwards compatible with ESLint v8 and lower? |
Yep! This shouldn't impact any earlier versions. The "legacy" configs are exported from the same place as before ( |
I also updated the README to include usage examples.
Example usage:
Closes #28313