Schedule prerender after something suspends #30800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
anandfresh
reviewed
Aug 24, 2024
acdlite
force-pushed
the
add-prerendering-phase
branch
from
6c714da
to
d6913dd
Compare
acdlite
force-pushed
the
add-prerendering-phase
branch
from
d6913dd
to
88050a4
Compare
|
Comparing: 8b4c54c...ff0b173 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
acdlite
force-pushed
the
add-prerendering-phase
branch
from
88050a4
to
b9755e7
Compare
sebmarkbage
approved these changes
Aug 27, 2024
eps1lon
reviewed
Aug 27, 2024
There was a problem hiding this comment.
some nits. Test changes make sense given the explainer.
Still need to wrap my head around
For example, during a transition, if something suspends, we should not speculatively prerender siblings that will be replaced by a fallback in the UI until after the fallback has been shown to the user.
is there a test for this scenario?
|
|
||
| // If there are no unsuspended or pinged lanes, that implies that we're | ||
| // performing a prerender. | ||
| return unblockedLanes === 0; |
There was a problem hiding this comment.
Suggested change
| return unblockedLanes === 0; | |
| return unblockedLanes === NoLanes; |
| @@ -191,6 +199,7 @@ describe('ReactCache', () => { | |||
| } | |||
| }); | |||
|
|
|||
| // @gate enableSiblingPrerendering | |||
There was a problem hiding this comment.
Shouldn't this be inlined into a different set of assertions?
|
An internal test run of this looks good so far (https://fburl.com/diff/bijwbv45) |
acdlite
force-pushed
the
add-prerendering-phase
branch
from
b9755e7
to
a990e45
Compare
acdlite
force-pushed
the
add-prerendering-phase
branch
from
a990e45
to
a4fd292
Compare
acdlite
force-pushed
the
add-prerendering-phase
branch
from
a4fd292
to
f9275aa
Compare
Adds the concept of a "prerender". These special renders are spawned whenever something suspends (and we're not already prerendering). The purpose is to move speculative rendering work into a separate phase that does not block the UI from updating. For example, during a transition, if something suspends, we should not speculatively prerender siblings that will be replaced by a fallback in the UI until *after* the fallback has been shown to the user.
acdlite
force-pushed
the
add-prerendering-phase
branch
from
f9275aa
to
42b8a5f
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Adds the concept of a "prerender". These special renders are spawned whenever something suspends (and we're not already prerendering). The purpose is to move speculative rendering work into a separate phase that does not block the UI from updating. For example, during a transition, if something suspends, we should not speculatively prerender siblings that will be replaced by a fallback in the UI until *after* the fallback has been shown to the user. DiffTrain build for commit e10e868.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Adds the concept of a "prerender". These special renders are spawned whenever something suspends (and we're not already prerendering). The purpose is to move speculative rendering work into a separate phase that does not block the UI from updating. For example, during a transition, if something suspends, we should not speculatively prerender siblings that will be replaced by a fallback in the UI until *after* the fallback has been shown to the user. DiffTrain build for [e10e868](e10e868)
jayrito12
added a commit
to jayrito12/reactjcl
that referenced
this pull request
Sep 4, 2024
Adds the concept of a "prerender". These special renders are spawned whenever something suspends (and we're not already prerendering). The purpose is to move speculative rendering work into a separate phase that does not block the UI from updating. For example, during a transition, if something suspends, we should not speculatively prerender siblings that will be replaced by a fallback in the UI until *after* the fallback has been shown to the user.
This was referenced Sep 5, 2024
This was referenced Sep 12, 2024
gnoff
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`** [diff facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d) <details> <summary>React upstream changes</summary> - facebook/react#30952 - facebook/react#30950 - facebook/react#30946 - facebook/react#30934 - facebook/react#30947 - facebook/react#30945 - facebook/react#30938 - facebook/react#30936 - facebook/react#30879 - facebook/react#30888 - facebook/react#30931 - facebook/react#30930 - facebook/react#30832 - facebook/react#30929 - facebook/react#30926 - facebook/react#30925 - facebook/react#30905 - facebook/react#30900 - facebook/react#30910 - facebook/react#30906 - facebook/react#30899 - facebook/react#30919 - facebook/react#30708 - facebook/react#30907 - facebook/react#30897 - facebook/react#30896 - facebook/react#30895 - facebook/react#30887 - facebook/react#30889 - facebook/react#30893 - facebook/react#30892 - facebook/react#30891 - facebook/react#30882 - facebook/react#30881 - facebook/react#30870 - facebook/react#30849 - facebook/react#30878 - facebook/react#30865 - facebook/react#30869 - facebook/react#30875 - facebook/react#30800 - facebook/react#30762 - facebook/react#30831 - facebook/react#30866 - facebook/react#30853 - facebook/react#30850 - facebook/react#30847 - facebook/react#30842 - facebook/react#30837 - facebook/react#30848 - facebook/react#30844 - facebook/react#30839 - facebook/react#30802 - facebook/react#30841 - facebook/react#30827 - facebook/react#30826 - facebook/react#30825 - facebook/react#30824 - facebook/react#30840 - facebook/react#30838 - facebook/react#30836 - facebook/react#30819 - facebook/react#30816 - facebook/react#30814 - facebook/react#30813 - facebook/react#30812 - facebook/react#30811 </details> --------- Co-authored-by: vercel-release-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a series of PRs related to sibling prerendering. I have the implementation working locally, but still working on splitting it up into a reasonable sequence of steps so we can land it incrementally. There's likely to be some regressions due to the scope of the change, so I've also done my best to keep the change behind a feature flag.
Opening this in draft mode while I continue to work on updating the test suite, which requires many changes.
Adds the concept of a "prerender". These special renders are spawned whenever something suspends (and we're not already prerendering).
The purpose is to move speculative rendering work into a separate phase that does not block the UI from updating. For example, during a transition, if something suspends, we should not speculatively prerender siblings that will be replaced by a fallback in the UI until after the fallback has been shown to the user.