Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Improve Layering Between Console and Renderer #30925

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[DevTools] Improve Layering Between Console and Renderer #30925

merged 4 commits into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. Move getCurrentFiber into onErrorOrWarning so that it's encapsulated … 

    …in the renderer

We also don't need an error in that implementation affect the component stacks. (Moving try/catch.)
    @sebmarkbage
    sebmarkbage committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    dfd8f85 View commit details
    Browse the repository at this point in the history

  2. Move getComponentStack computation into renderer 

    The console patching shouldn't need to know about Fibers.
    @sebmarkbage
    sebmarkbage committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a2af0d7 View commit details
    Browse the repository at this point in the history

  3. Delete early patching registerRendererWithConsole 

    This doesn't inject onErrorAndWarning and getComponentStack so it doesn't
really do anything useful anyway.
    @sebmarkbage
    sebmarkbage committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a09d1c7 View commit details
    Browse the repository at this point in the history

  4. Remove the actual "renderer" from registerRenderer 

    These internals are not needed. All we need is the onErrorOrWarning and
getComponentStack helpers.
    @sebmarkbage
    sebmarkbage committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c664b9b View commit details
    Browse the repository at this point in the history