Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use incrementing numerical IDs to identify DOM components #5205

Merged
merged 18 commits into from
Nov 4, 2015
Merged

Use incrementing numerical IDs to identify DOM components #5205

merged 18 commits into from
Nov 4, 2015

Commits on Nov 4, 2015

  1. Make ReactEmptyComponent-test not swallow logs

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    19e2cf5 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete tests with new tree-walking

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    5becbe3 View commit details
    Browse the repository at this point in the history

  3. Make ReactDOMComponent-test pass with useCreateElement

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    276ef73 View commit details
    Browse the repository at this point in the history

  4. Always do useCreateElement for updates 

    Initial render can still be a markup string.
    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    5a7c273 View commit details
    Browse the repository at this point in the history

  5. ReactDOMComponentTree 

    New module! With this, we have a new module that uses the component tree to store DOM nodes. Most of the logic in this file relates to markup adoption -- if we were to drop that (along with server rendering) this file could just be a `return inst._nativeNode;`.

This works with useCreateElement only because we need to reference each node as it's created.

Events is now the only thing using ReactMount.getNode -- I'll introduce pointers back from the DOM nodes (and a `ReactDOMComponentTree.getInstanceFromNode`) and make that work.
    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    ce52845 View commit details
    Browse the repository at this point in the history

  6. Add functions to find the instance given a node

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    6d20556 View commit details
    Browse the repository at this point in the history

  7. Events: Pass native instances up until propagation 

    Next step: take advantage of having the native instances in EventPropagators instead of converting right back to IDs.
    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    f470cb8 View commit details
    Browse the repository at this point in the history

  8. Propagate events based on component tree, not IDs

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    d11ccd6 View commit details
    Browse the repository at this point in the history

  9. put/deleteListener take an instance, not an ID 

    This removes SimpleEventPlugin's dependency on ReactMount.getID.
    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    796f8c3 View commit details
    Browse the repository at this point in the history

  10. Kill ReactMount.getNode/getID/purgeID with fire

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    4ba0e95 View commit details
    Browse the repository at this point in the history

  11. Perf: Static children count for wasted time

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    5d94d7d View commit details
    Browse the repository at this point in the history

  12. Stop relying on hierarchical IDs in ReactDefaultPerf

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    663c4b7 View commit details
    Browse the repository at this point in the history

  13. Turn ReactInstanceHandles-test into ReactDOMTreeTraversal-test 

    This test relied on the fact that ReactDOMComponent still produced hierarchical IDs -- although this module could be used standalone, we're replacing it completely so it makes more sense to just move the tests over to test ReactDOMTreeTraversal.
    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    f06ddf7 View commit details
    Browse the repository at this point in the history

  14. Use incrementing numerical IDs to identify DOM components

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    e48c8be View commit details
    Browse the repository at this point in the history

  15. Remove now-unused _rootNodeID from composites

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    3cebada View commit details
    Browse the repository at this point in the history

  16. Remove unused modules 

    - Remove last references to ReactInstanceHandles (still used in responder unit test)
- Remove ClientReactRootIndex/ServerReactRootIndex
    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    35543c6 View commit details
    Browse the repository at this point in the history

  17. Add hooks back for devtools

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    b80f676 View commit details
    Browse the repository at this point in the history

  18. Don't put IDs in the DOM in createElement mode

    @sophiebits
    sophiebits committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    c193d1a View commit details
    Browse the repository at this point in the history