Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all SVG attributes through #5714

Merged
merged 4 commits into from
Dec 25, 2015
Merged

Pass all SVG attributes through #5714

merged 4 commits into from
Dec 25, 2015

Commits on Dec 24, 2015

  1. Pass SVG attributes through

    All attributes defined on SVG elements will now be passed directly regardless of the whitelist. The casing specified by user will be preserved, and setAttribute() will be used.
    
    In the future we will remove support for the camel case aliases to the hyphenated attributes. For example, we currently map `strokeWidth` to `stroke-width` but this is now deprecated behind a warning. When we remove support for this we can remove some of the code paths introduced in this commit.
    
    The purpose of this change is to stop maintaining a separate SVG property config. The config still exists for two purposes:
    
    * Allow a migration path for deprecated camelcased versions of hyphenated SVG attributes
    * Track special namespaced attributes (they still require a whitelist)
    
    However it is no longer a blocker for using new non-namespaced SVG attributes, and users don't have to ask us to add them to the whitelist.
    
    Fixes #1657
    gaearon committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    232a47a View commit details
    Browse the repository at this point in the history
  2. Move SVG attribute deprecation warnings into a devtool

    In #5590 a new system was introduced for tracking dev-time warnings.
    This commit uses it for reporting SVG attribute deprecation warnings.
    gaearon committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    251d6c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2015

  1. Configuration menu
    Copy the full SHA
    f27e3aa View commit details
    Browse the repository at this point in the history
  2. Use JSX in the new tests

    gaearon committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    98a7100 View commit details
    Browse the repository at this point in the history