Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React v15 Blog Post #6396

Closed
wants to merge 3 commits into from
Closed

Add React v15 Blog Post #6396

wants to merge 3 commits into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 1, 2016

This adds the blog post for React 15 release.
There are still a couple of action items here that I intend to go over on Monday:

  • Include info about more recently merged warnings
  • Experiment with linking to pull requests for community contributions more extensively

Feedback is welcome!
Dating this as Monday.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

8 similar comments
@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@koba04
Copy link
Contributor

koba04 commented Apr 5, 2016

@gaearon I fixed a small memory leak, if I’m not mistaken. 😄
#5840

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 5, 2016

This is now done. Some proofreading and link-clicking would be nice. 😄

Personally I like the new style with PR links. My only concern is that we don’t have target="_blank" for external links but we probably should. But I’m too lazy to fix it now. I’d also rather fix it on JS side.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 5, 2016

Note that it may be a tiny bit unconventional to use usernames to link to PRs. I think it makes sense though. At first I used ([@user] in [#PR]) but it was way too noisy, and PR numbers don’t really convey any information. I think linking from user names to PRs is a good tradeoff between keeping the log readable, acknowledging the contributors, and linking to detail for interested parties.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

@facebook-github-bot
Copy link

@gaearon updated the pull request.

- If you use a minified copy of the _development_ build, React DOM kindly encourages you to use the faster production build instead.
<small>[@spicyj](https://github.com/spicyj) in [#5083](https://github.com/facebook/react/pull/5083)</small>

- React DOM: When specifying a unit-less CSS value as a string, a future version will not add `px` automatically. This version now warns in this case (ex: writing `style={{'{{'}}width: '300'}}`. Unitless *number* values like `width: 300` are unchanged.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style={{'{{'}}width: '300'}} does not look right. It should look like this: style={{width: '300'}}.
Also there's missing a close bracket I think.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown parser on their site is different than GH, unfortunately, but this works on the blog post display just fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DerNivel jekyll (the blog compiler) interprets {{ specially, so this is escaping it for jekyll.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. We’ve been doing that in other posts so I followed the same pattern. Obviously not very happy with it but hey, at least this doesn’t break Jekyll!

@zpao
Copy link
Member

zpao commented Apr 7, 2016

Flattened and committed directly for the release - 75f4925. If you see any grammar changes, let's just open a PR and we'll make sure it gets synced, thanks!

@zpao zpao closed this Apr 7, 2016
@gaearon gaearon deleted the gaearon-patch-1 branch April 8, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants