-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React v15 Blog Post #6396
Add React v15 Blog Post #6396
Conversation
@gaearon updated the pull request. |
8 similar comments
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
This is now done. Some proofreading and link-clicking would be nice. 😄 Personally I like the new style with PR links. My only concern is that we don’t have |
Note that it may be a tiny bit unconventional to use usernames to link to PRs. I think it makes sense though. At first I used |
@gaearon updated the pull request. |
@gaearon updated the pull request. |
- If you use a minified copy of the _development_ build, React DOM kindly encourages you to use the faster production build instead. | ||
<small>[@spicyj](https://github.com/spicyj) in [#5083](https://github.com/facebook/react/pull/5083)</small> | ||
|
||
- React DOM: When specifying a unit-less CSS value as a string, a future version will not add `px` automatically. This version now warns in this case (ex: writing `style={{'{{'}}width: '300'}}`. Unitless *number* values like `width: 300` are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style={{'{{'}}width: '300'}}
does not look right. It should look like this: style={{width: '300'}}
.
Also there's missing a close bracket I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown parser on their site is different than GH, unfortunately, but this works on the blog post display just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DerNivel jekyll (the blog compiler) interprets {{
specially, so this is escaping it for jekyll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. We’ve been doing that in other posts so I followed the same pattern. Obviously not very happy with it but hey, at least this doesn’t break Jekyll!
Flattened and committed directly for the release - 75f4925. If you see any grammar changes, let's just open a PR and we'll make sure it gets synced, thanks! |
This adds the blog post for React 15 release.
There are still a couple of action items here that I intend to go over on Monday:
Feedback is welcome!
Dating this as Monday.