Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Streaming server renderer on top of existing client checksum validator #6836

Closed
wants to merge 43 commits into from
Closed

[WIP] Streaming server renderer on top of existing client checksum validator #6836

wants to merge 43 commits into from

Commits on May 16, 2016

  1. Interim checking with a bunch of unit tests for server rendering, and… 

    … the unit tests all pass right now. Still more to add.
    @aickin
    aickin committed May 16, 2016
    Configuration menu
    Copy the full SHA
    a48b7b3 View commit details
    Browse the repository at this point in the history

  2. Fixed a bunch of tests up to run with warnings correctly.

    @aickin
    aickin committed May 16, 2016
    Configuration menu
    Copy the full SHA
    2fef93f View commit details
    Browse the repository at this point in the history

  3. Converted two tests to use the itRenders framework. All tests passing.

    @aickin
    aickin committed May 16, 2016
    Configuration menu
    Copy the full SHA
    b4defa7 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2016

  1. Moved a bunch of tests from the markup match/mismatch section to the … 

    …basic components section and upgraded several of them to use itRenders
    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    3aedcb9 View commit details
    Browse the repository at this point in the history

  2. Ported a few more tests to itRenders

    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    cca6d7d View commit details
    Browse the repository at this point in the history

  3. Found out that unit tests in this codebase automagically have access … 

    …to pit()
    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    2985e83 View commit details
    Browse the repository at this point in the history

  4. Interim checkin of new renderer with the new unit tests but old valid… 

    …ator. A bunch of unit tests still fail (19 in server render test and more overall).
    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    bb705fb View commit details
    Browse the repository at this point in the history

  5. Fixed a problem that was happening with server warning messages disab… 

    …ling client warning messages.
    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    9842aa9 View commit details
    Browse the repository at this point in the history

  6. Fixed a bug where the tests were depending on the behavior that serve… 

    …r warning messages disable client warning messages.
    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    77b3b90 View commit details
    Browse the repository at this point in the history

  7. Oops, forgot to add ReactServerRenderingAsync to the codebase.

    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    1eeaa6b View commit details
    Browse the repository at this point in the history

  8. Fixed the remaining server rendering test failures. There are still s… 

    …ome failures in ReactComponentTreeDevtool.
    @aickin
    aickin committed May 18, 2016
    Configuration menu
    Copy the full SHA
    de518d1 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2016

  1. Removed ReactComponentTreeDevtool tests for server rendering.

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    0a2b824 View commit details
    Browse the repository at this point in the history

  2. removed an error check that is now unnecessary

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    41a0cb1 View commit details
    Browse the repository at this point in the history

  3. Added Adler32 hash to streaming render, but no tests yet.

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    edb8df4 View commit details
    Browse the repository at this point in the history

  4. Added stream tests, though I can't test them against this branch.

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    155d993 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    c0dcf9e View commit details
    Browse the repository at this point in the history

  6. Scripts don't run until you add them to the document. Fixed that.

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    53ddeda View commit details
    Browse the repository at this point in the history

  7. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    a06b221 View commit details
    Browse the repository at this point in the history

  8. Fixed some bugs in unit tests; still failing with stream tests that h… 

    …ave warnings.
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    dcd4139 View commit details
    Browse the repository at this point in the history

  9. Added warning counts to the stream rendering functions.

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    d2b032a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    8612827 View commit details
    Browse the repository at this point in the history

  11. Share a little bit of logic with ReactDOMComponent, and remove some u… 

    …nnecessary special cases.
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    32e0c72 View commit details
    Browse the repository at this point in the history

  12. Small refactor to make propsToAttributes more understandable

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    a929fa1 View commit details
    Browse the repository at this point in the history

  13. I missed changing one of the call sites in the last checkin.

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    8ed3f29 View commit details
    Browse the repository at this point in the history

  14. Made the internal class for async render act more like a generator. F… 

    …ive tests are broken; will be fixed on next merge from test branch.
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    ffaea33 View commit details
    Browse the repository at this point in the history

  15. Modified the streaming tests to catch errors thrown when render() is … 

    …first called internally.
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    586d625 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    3f59d81 View commit details
    Browse the repository at this point in the history

  17. Converted several tests to itRenders

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    aa87896 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'added-unit-tests' into added-unit-tests-with-stream

    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    e0ff41c View commit details
    Browse the repository at this point in the history

  19. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 19, 2016
    Configuration menu
    Copy the full SHA
    b7291af View commit details
    Browse the repository at this point in the history

Commits on May 20, 2016

  1. Added a few tests for non-standard and custom elements.

    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    50b65f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'added-unit-tests' into added-unit-tests-with-stream

    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    7da5609 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    79f70ba View commit details
    Browse the repository at this point in the history

  4. Added support for attributes on custom elements in the new renderer; … 

    …as a result ended up centralizing more markup generation logic.
    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    b220514 View commit details
    Browse the repository at this point in the history

  5. Fixing some lint problems

    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    52a96dc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into added-unit-tests

    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    8e35f6c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'added-unit-tests' into added-unit-tests-with-stream

    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    37a88a6 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'added-unit-tests-with-stream' into new-server-renderer-… 

    …old-client-validator
    @aickin
    aickin committed May 20, 2016
    Configuration menu
    Copy the full SHA
    67d3494 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2016

  1. Fixed tests that were broken by the merge. Added support for debug to… 

    …oling and uncommented out the ReactComponentTreeDevtool-test server rendering piece. There are still two tests that don't pass, and they have been xit'ed out.
    @aickin
    aickin committed May 22, 2016
    Configuration menu
    Copy the full SHA
    cc42fb6 View commit details
    Browse the repository at this point in the history

  2. Added some comments and renamed 'tree' to 'node' in the render code.

    @aickin
    aickin committed May 22, 2016
    Configuration menu
    Copy the full SHA
    0f14e3e View commit details
    Browse the repository at this point in the history

  3. Fixed packaging issues and one runtime error.

    @aickin
    aickin committed May 22, 2016
    Configuration menu
    Copy the full SHA
    fb63b3c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2016

  1. Two perf enhancements. One is to streamline html escaping for strings… 

    … that don't have special characters. The other is an inlining of creating the data-reactid
    @aickin
    aickin committed May 24, 2016
    Configuration menu
    Copy the full SHA
    5203d68 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2016

  1. Fixing some errors discovered when I tried to run the benchmark scrip… 

    …t against this branch.
    @aickin
    aickin committed May 31, 2016
    Configuration menu
    Copy the full SHA
    325fca4 View commit details
    Browse the repository at this point in the history