Add “Don't Call PropTypes” warning #7219
Conversation
ghost
added
| var error = apiShape(json, 'response'); | ||
| ``` | ||
|
|
||
| If you depend on using PropTypes like this, we encourage you to use or create a fork of PropTypes (such as [these](https://github.com/aackerman/PropTypes) [two](https://github.com/developit/proptypes) packages). |
There was a problem hiding this comment.
Do you think we'll ever ship our own standalone package? Should we mention that we might do that alongside the major version change?
There was a problem hiding this comment.
Do you mean we could delegate to that package normally but replace with throwing shims in prod?
There was a problem hiding this comment.
I thought we talked about potentially splitting the PropTypes out from the main package and shipping it as a standalone thing. But I guess that's tangential and not worth mentioning until/if we do it. Just ignore me.
|
Thanks for doing this! I filed #7220 as a reminder to actually create that short url when we ship. (note: I got rid of the tracking milestone because this is docs and we'll cherry-pick to stable separately) |
|
Oops, meant to get this in before shipping 15.3.0… will land now. |
Followup to facebook#7219, which was created before the Jekyll 3 upgrade, which needs the permalink field.
Followup to #7219, which was created before the Jekyll 3 upgrade, which needs the permalink field.
(cherry picked from commit 8329856)
This warning was introduced in #7132.
This document should be available by
https://fb.me/react-warning-dont-call-proptypes.