Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoint/rollback to ReactNativeReconcileTransaction #7619

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

millermedeiros
Copy link
Contributor

kinda of a follow up to #7558 and #7567

I could not find a way to easily add tests for it - createReactNativeComponentClass.js doesn't allow passing the lifecycle methods, would have to shave too many yaks and I'm busy with other tasks... but I believe this is the expected behavior.

/cc @spicyj

@sophiebits
Copy link
Contributor

Thanks!

@millermedeiros millermedeiros deleted the nativecheckpoint branch August 31, 2016 05:35
@zpao zpao modified the milestones: 15.3.2, 15-next Sep 8, 2016
zpao pushed a commit that referenced this pull request Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants