Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling it modern feels weird although modern and classic are the internal folder names.
There’s been some chatter about
createClass
andPropTypes
being generally in maintenance mode asclass
andFlow
are the future. I was playing around with the build system anyway (see #7850 and https://twitter.com/iamdustan/status/783701952483856384) so decided to try to create a build removingcreateClass
andDOMFactories
. PotentiallycreateFactory
andcreateMixin
could be removed as well.The build of react-slim.js vs react.js is displayed in the screenshot below:
Diff
Removing PropTypes may be problematic due to
context
still using it? This is part of an experiment I’m considering that would convert https://github.com/reactjs/react-codemod/blob/master/transforms/class.js to ababel
transform to run over arbitrary components outside of direct control (akababel
overnode_modules
. Heresy, heresy!)