Move setState callback to right after didUpdate #8204
Merged
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much easier to do it this way in Fiber and there shouldn't be much observable difference.
|
Not sure how related this is, but there's also a bug in stack where Should that be dealt with separately? |
|
I'll fix that now but in a separate PR. |
|
LGTM but someone who knows stack should give final approval |
sebmarkbage
approved these changes
Nov 5, 2016
|
Is there any chance this change makes it into a React 15.x release? This actually fixes an issue in the next version of react-redux? Would be great to have this sooner than React 16. |
|
Since it's a potentially breaking change, it can only land in a major version. |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
It's much easier to do it this way in Fiber and there shouldn't be much observable difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much easier to do it this way in Fiber and there shouldn't be much observable difference.