Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Add more tests and fix an issue with incremental error handling #8212

Closed
wants to merge 3 commits into from
Closed

[Fiber] Add more tests and fix an issue with incremental error handling #8212

wants to merge 3 commits into from

Commits on Nov 5, 2016

  1. Add more tests for incremental error handling 

    These tests are currently failing:

  ✕ catches render error in a boundary during partial deferred mounting
  ✕ catches render error in a boundary during animation mounting
  ✕ propagates an error from a noop error boundary during full deferred mounting
  ✕ propagates an error from a noop error boundary during partial deferred mounting
  ✕ propagates an error from a noop error boundary during animation mounting

The observed behavior is that unstable_handleError() unexpected gets called twice:

      "ErrorBoundary render success",
      "BrokenRender",
      "ErrorBoundary unstable_handleError",
  +   "ErrorBoundary render success",
  +   "BrokenRender",
  +   "ErrorBoundary unstable_handleError",
      "ErrorBoundary render error"
    @gaearon
    gaearon committed Nov 5, 2016
    Configuration menu
    Copy the full SHA
    acb896d View commit details
    Browse the repository at this point in the history

  2. Always reuse progressChild when starting Task work

    @gaearon
    gaearon committed Nov 5, 2016
    Configuration menu
    Copy the full SHA
    12c7d2d View commit details
    Browse the repository at this point in the history

  3. Verify batched updates get scheduled despite errors

    @gaearon
    gaearon committed Nov 5, 2016
    Configuration menu
    Copy the full SHA
    00ab372 View commit details
    Browse the repository at this point in the history