Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure code to work around a Rollup bug #8384

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 22, 2016

This PR is directly again 15-stable because it's fixed in #8309 but tricky to cherry-pick.

This fixes #8318.

It's not technically our bug, but it is a regression for Rollup users and it's easy for us to avoid.
In fact we already fixed this in master via #8309 because of the linter update.

@zpao
Copy link
Member

zpao commented Nov 22, 2016

Let's fix the 15-dev branch and then update the PR to point at that. That way stable branch at any point will always build a release version and not an intermediate release. Otherwise 👍

RRM should do the branch cleanup - I can double check and push it.

@gaearon gaearon changed the base branch from 15-stable to 15-dev November 22, 2016 19:17
@sophiebits sophiebits merged commit 9941c48 into facebook:15-dev Nov 23, 2016
@gaearon gaearon added this to the 15.4.1 milestone Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants