Add callback validation to fiber-based renderers #8677
Conversation
|
Nit: can we also change Stack to use it? |
|
Yeah, I was already making that change. 😁 Realized they were super redundant after I pushed the Fiber change. |
|
It's only ever used in |
I don't understand your comment @acdlite. |
|
To clarify: rather than validating separately in |
|
There's nothing renderer specific about |
bvaughn
force-pushed
the
add-callback-validation-to-dom-render
branch
from
5559da7
to
8d9a1ad
Compare
|
Thanks for clarifying @acdlite. That's a nice improvement since it will also add callback validation for other renderer types. This PR has been updated with that change. |
bvaughn
changed the title
| @@ -204,7 +205,9 @@ function findInsertionPosition(queue, update) : Update | null { | |||
| // we shouldn't make a copy. | |||
| // | |||
| // If the update is cloned, it returns the cloned update. | |||
| function insertUpdate(fiber : Fiber, update : Update, methodName : ?string) : Update | null { | |||
| function insertUpdate(fiber : Fiber, update : Update, methodName : string) : Update | null { | |||
There was a problem hiding this comment.
Since methodName is now always a string, we can remove the typeof check on line 215.
bvaughn
force-pushed
the
add-callback-validation-to-dom-render
branch
from
8d9a1ad
to
bc05ef1
Compare
| formatUnexpectedArgument(callback) | ||
| ); | ||
| }, | ||
| validateCallback: validateCallback, |
There was a problem hiding this comment.
Why is this indirection useful? Can we just import it directly in the calling file instead?
There was a problem hiding this comment.
It isn't! Good catch. Removed. 😄
Moved ReactFiberClassComponent validateCallback() helper function into a standalone util used by both fiber and stack implementations. Validation now happens in ReactFiberUpdateQueue so that non-DOM renderers will also benefit from it.
bvaughn
force-pushed
the
add-callback-validation-to-dom-render
branch
from
bc05ef1
to
8fbcd49
Compare
|
Another one we can easily make a warning. Should we do a pass through and see how many of these we can make into warnings to help file size? |
|
Nit: Same as #8639 (comment) |
Yes, I'll add to umbrella. |
Moved
ReactFiberClassComponentvalidateCallback()helper function into a standalone util used by both fiber and stack implementations. Validation now happens inReactFiberUpdateQueueso that non-DOM renderers will also benefit from it.This fixes 2 failing fiber tests.