Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some server rendering unit tests. #9055

Merged
merged 7 commits into from
Mar 1, 2017
Merged

Adding some server rendering unit tests. #9055

merged 7 commits into from
Mar 1, 2017

Commits on Feb 23, 2017

  1. Added a handful of SSR unit tests, ported from a previous pull request.

    @aickin
    aickin committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    437d029 View commit details
    Browse the repository at this point in the history

  2. Fixing linting errors

    @aickin
    aickin committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    7c85408 View commit details
    Browse the repository at this point in the history

  3. Fixed a test helper function to properly report errors.

    @aickin
    aickin committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    c1d9787 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2017

  1. Merge branch 'master' into server-render-unit-tests

    @aickin
    aickin committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    5531bf3 View commit details
    Browse the repository at this point in the history

  2. Un-nested the new rendering tests. Updated the fiber test passing/not… 

    … passing lists.
    @aickin
    aickin committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    9257660 View commit details
    Browse the repository at this point in the history

  3. Edited to comply with the react/jsx-space-before-closing eslint rule,… 

    … which will soon be merged into master.
    @aickin
    aickin committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    08b4936 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2017

  1. Response to code review from @spicyj. Moved tests to separate file, r… 

    …eworked wording of test names, corrected use of canUseDom, and simplified tests against tagName. Thanks for the help, @spicyj!
    @aickin
    aickin committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    a91c836 View commit details
    Browse the repository at this point in the history