Fix record-tests script #9060
Merged
Fix record-tests script #9060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of readConfig changed slightly in Jest 0.19.
bvaughn
approved these changes
Feb 24, 2017
|
I'm going to merge this before CI finishes so that it doesn't block any other PRs today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to run the record-test script. Did some digging and turns out the result of readConfig changed slightly in Jest 0.19, which we recently updated to. This fixes the script.
I'm not entirely sure why this didn't break CI...
To test, make sure you run yarn so you're on the latest version of jest.