Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to deprecate React<CSS>TransitionGroup #9336

Closed

Conversation

flarnie
Copy link
Contributor

@flarnie flarnie commented Apr 5, 2017

Another piece of updating the docs for the 15.5 release.

  • removes link to the docs about ReactCSSTransitionGroup and
    ReactTransitionGroup from the main navigation
  • updates 'prev' and 'next' pointers to skip this page
  • adds deprecation warning to the top of the page
  • remove references to these modules from the packages README
  • updates 'add-ons' main page to list this as a deprecated add-on

 - removes link to the docs about `ReactCSSTransitionGroup` and
   `ReactTransitionGroup` from the main navigation
 - updates 'prev' and 'next' pointers to skip this page
 - adds deprecation warning to the top of the page
 - remove references to these modules from the packages README
 - updates 'add-ons' main page to list this as a deprecated add-on
@flarnie flarnie added this to the 15-hipri milestone Apr 5, 2017
@flarnie flarnie requested review from bvaughn and gaearon April 5, 2017 03:28
- id: animation
title: Animation
- id: shallow-renderer
title: Shallow Renderer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from rebasing off my other documentation updates.

@@ -4,8 +4,8 @@ title: Keyed Fragments
permalink: docs/create-fragment.html
layout: docs
category: Add-Ons
prev: animation.html
next: perf.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the perf pointer change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was incorrect, as the diff in the other PR points out and fixes. When I cherry-picked this to make a stand-alone branch/PR I either kept this correction or made it again because it was convenient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I didn't make the connection.

@flarnie flarnie mentioned this pull request Apr 7, 2017
2 tasks
@acdlite acdlite closed this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants