Update minified version of 'create-react-class' #9939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
We ran the latest version of
addons/create-react-class/create-react-class.js
through https://jscompress.com/why make this change?:
The last corner case I'm thinking of is this:
createClass
deprecation warning never went out in 15.5, and is going out now for real in 15.6.createClass
UMD build is broken for AMD/CommonJS, but we fixed it. But not for the minified version of the file.We can do a quick 15.5.4 release of that package, we would at least fix that case. Seemed worth doing since it took 30 seconds.
This diverges from what @gaearon is doing to fix the add-ons. I would
probably try to use cherry-pick and interactive rebase to move this
commit to right after
ce3ecfb
and then do the patch release of
create-react-class
from that spot inhistory.
Alternately I can merge this into the forked branch
15.6-before-addon-reconstruction
and then do the patch release fromthere.
test plan:
I didn't test this. Ideally minifying this file won't break anything,
and it's high cost to test add-ons until we have some repeatable tests
in place.
issue:
#9765
Before submitting a pull request, please make sure the following is done:
master
.npm test
).npm run lint
).npm run prettier
).npm run flow
)../scripts/fiber/record-tests
before submitting the pull request, and commit the resulting changes.