Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] remove clientMutationId and Relay Mutation spec #2401

Closed
wants to merge 1 commit into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 6, 2018

RelayModern has no requirements on mutations beyond the general mutation specs. Specifically, the additional requirements that are no longer required are:

  • clientMutationId (even RelayClassic only required this because of FB internal reasons)
  • $input objects, with RelayModern the input to mutations can come either as one big object or multiple mutation arguments.

@robrichard
Copy link
Contributor

@kassens there is one bug that some people have been using clientMutationId to work around. I have the details in my PR: #2349

@kassens
Copy link
Member Author

kassens commented Dec 10, 2019

Now that #2349 finally landed, I think we're ready for this too!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kassens merged this pull request in 3838691.

jstejada pushed a commit that referenced this pull request Dec 19, 2019
Summary:
RelayModern has no requirements on mutations beyond the general mutation specs. Specifically, the additional requirements that are no longer required are:

- `clientMutationId` (even RelayClassic only required this because of FB internal reasons)
- `$input` objects, with RelayModern the input to mutations can come either as one big object or multiple mutation arguments.
Pull Request resolved: #2401

Reviewed By: tyao1

Differential Revision: D18917450

Pulled By: kassens

fbshipit-source-id: 4a5be749389872c62db6bde63e0c6b38f839b02c
@julioxavierr
Copy link

julioxavierr commented Dec 23, 2019

@kassens

I saw this in breaking changes for v8:

Mutations are committed to unique root ids #2349. In mutation updaters, fields in the mutation will no longer be available in the store root returned from store.getRoot. Usages like store.getRoot().getLinkedRecord('create_comment_mutation') will break.

Will usages like store.getLinkedRecord('create_comment_mutation') also break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants