Adds back the missing resolver type import in Typescript files #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey. I'm hitting an internal infra issue importing this PR. I think there's some cases where if a PR needs to get rebased on import it can time out. Sorry to ask this, but do you mind reopening this as a new PR? |
|
@captbaritone do we still need this though? Didn't you do almost exactly the same here? |
|
Ah, right. I last track of that. Should we just close this PR? |
|
Yep, closed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to improve Typescript types we made the wrong assumption that the resolver type import was always unused in Typescript files.
We missed the fact that it is used in the scenario where
RelayResolverTypeis provided as the return value of a resolver. (See issue #4790)The TODO's remain as there is still work to do to add Context support to the resolvers.