reviewstack: fix github stacked diff display #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github diffs were showing the full set of commits in the stack rather than just the commits for the given PR version
gitHubPullRequestComparableVersions was returning null for base commit, which meant we always fell back on the } else if (afterBaseCommitID != null) { branch of gitHubPullRequestVersionDiff. That fallback used to work fine, but now its giving us the base of the full stack rather than the base of the PR. I don't know how it worked before (perhaps github api behaviour changed?), but there you go!
Fix is to use the version.baseParent in gitHubPullRequestComparableVersions, which has the right value in it.
Test Plan:
yarn test --watchAll=false
Local build and run, I'll add some pictures on the PR
|
@sggutier has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Is there a timeline for reviewstack deployments? Curious when we can expect to see this fix, since it's causing reviews to be pretty hard atm |
|
We don't really have one yet, but I just pushed a new deploy. That should include this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github diffs were showing the full set of commits in the stack rather than just the commits for the given PR version
gitHubPullRequestComparableVersions was returning null for base commit, which meant we always fell back on the } else if (afterBaseCommitID != null) { branch of gitHubPullRequestVersionDiff. That fallback used to work fine, but now its giving us the base of the full stack rather than the base of the PR. I don't know how it worked before (perhaps github api behaviour changed?), but there you go!
Fix is to use the version.baseParent in gitHubPullRequestComparableVersions, which has the right value in it.
Test Plan:
yarn test --watchAll=false
Local build and run:
Before, https://reviewstack.dev/facebookincubator/fizz/pull/96 shows changes for full stack:
After, http://localhost:3000/facebookincubator/fizz/pull/96 shows only relevant changes for PR:
