Skip to content

Commit

Permalink
Fix shadowed variable in watchman/Command.cpp
Browse files Browse the repository at this point in the history
Summary:
Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

**What's a shadowed variable?**

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D65347897

fbshipit-source-id: e1d6c59592526fa650aa84a1a31c2466ce5a26ab
  • Loading branch information
jdelliot authored and facebook-github-bot committed Nov 2, 2024
1 parent d02acb9 commit e2bb8f0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions watchman/Command.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ ResultErrno<folly::Unit> Command::run(
PduBuffer output_pdu_buffer;
if (persistent) {
for (;;) {
auto res = passPduToStdout(
auto result = passPduToStdout(
stream, buffer, output_format, output_pdu_buffer, pretty);
if (res.hasError()) {
return res;
if (result.hasError()) {
return result;
}
}
} else {
Expand Down

0 comments on commit e2bb8f0

Please sign in to comment.