Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a file is replaced by a directory #67

Closed
pclouds opened this issue Nov 24, 2014 · 1 comment
Closed

when a file is replaced by a directory #67

pclouds opened this issue Nov 24, 2014 · 1 comment

Comments

@pclouds
Copy link

pclouds commented Nov 24, 2014

The below commands create a file "df" first, then delete it and replace "df" with a directory. I would expect watchman to return "df" listing (i.e. df/file). Returning "df" only is probably not so helpful. I think this is a tricky case, if we can't do any better, I think the behavior should be documented somewhere (the same for replacing a directory with a file).

$ watchman watch /tmp/z
{
    "version": "2.9.3",
    "watch": "/tmp/z"
}
$ watchman find /tmp/z
{
    "version": "2.9.3",
    "clock": "c:1415969169:24704:6:3",
    "files": []
}
$ echo abc >df
$ watchman since /tmp/z/ "c:1415969169:24704:6:3"
{
    "version": "2.9.3",
    "clock": "c:1415969169:24704:6:8",
    "is_fresh_instance": false,
    "files": [
        {
            "dev": 24,
            "gid": 100,
            "name": "df",
            "exists": true,
            "size": 4,
            "mode": 33188,
            "uid": 1000,
            "mtime": 1416822103,
            "ctime": 1416822103,
            "ino": 89526671,
            "nlink": 1,
            "oclock": "c:1415969169:24704:6:5",
            "new": true,
            "cclock": "c:1415969169:24704:6:5"
        }
    ]
}
$ rm df ; mkdir df; echo df >df/file
$ watchman since /tmp/z/ "c:1415969169:24704:6:3"
{
    "version": "2.9.3",
    "clock": "c:1415969169:24704:6:12",
    "is_fresh_instance": false,
    "files": [
        {
            "dev": 24,
            "gid": 100,
            "name": "df",
            "exists": true,
            "size": 60,
            "mode": 16877,
            "uid": 1000,
            "mtime": 1416822140,
            "ctime": 1416822140,
            "ino": 89527844,
            "nlink": 2,
            "oclock": "c:1415969169:24704:6:10",
            "new": true,
            "cclock": "c:1415969169:24704:6:10"
        }
    ]
}
@pclouds
Copy link
Author

pclouds commented Nov 24, 2014

3.0.0 seems to fix this. Sorry for the noise.

@pclouds pclouds closed this as completed Nov 24, 2014
facebook-github-bot pushed a commit that referenced this issue Oct 16, 2020
…ps.py build (#67)

Summary:
Pull Request resolved: facebook/sapling#67

With this change it will be possible to build dependencies of and run integration tests using getdeps.py.

This is the first goal of Q4 as per https://fb.quip.com/v8YzAYNSYgot: "Get Open Source version of integration tests running on Legocastle".

Before this diff:
The OSS integration tests run now on GitHub by:
- Building some test dependencies with getdeps.py
- Building some test dependencies with homebrew/apt-get
- Running tests via python script

The OSS integration tests were not running on Sandcastle.

After this diff:
The OSS integration tests run on Github by:
- Building and executing tests via getdeps.py (execution of tests happens by getdeps.py calling Make calling python script)

The OSS integration tests run on Sandcastle using the same getdeps.py setup as Github.

Reviewed By: krallin

Differential Revision: D24253268

fbshipit-source-id: cae249b72d076222673b8bbe4ec21866dcdbb253
facebook-github-bot pushed a commit that referenced this issue Mar 3, 2022
Summary:
X-link: facebookincubator/hsthrift#67

Updating `googletest` from `1.8.0` to `1.10.0`

Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes

Differential Revision: D34351084

fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant