Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: fix build by adding missing files #2548

Merged
merged 1 commit into from
Mar 19, 2021
Merged

meson: fix build by adding missing files #2548

merged 1 commit into from
Mar 19, 2021

Conversation

SupervisedThinking
Copy link
Contributor

@facebook-github-bot
Copy link

Hi @SupervisedThinking!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@SupervisedThinking SupervisedThinking mentioned this pull request Mar 19, 2021
Merged
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

senhuang42
senhuang42 approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@senhuang42 senhuang42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @SupervisedThinking !

@Cyan4973 Cyan4973 merged commit 5158071 into facebook:dev Mar 19, 2021
@SupervisedThinking
Copy link
Contributor Author

Looks great! Thanks @SupervisedThinking !

Well @kloczek did the job but since I use meson too fixing it upstream made sense 👍🏻

@kloczek
Copy link

kloczek commented Mar 20, 2021

Sorry I was busy and had no time to prepare PR :/

@SupervisedThinking
Copy link
Contributor Author

Sorry I was busy and had no time to prepare PR :/

NP - since you posted the patch I could PR it 🥇

@muelli muelli mentioned this pull request Mar 22, 2021
Merged
@senhuang42 senhuang42 mentioned this pull request May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senhuang42 senhuang42 senhuang42 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.4.9: build fails
5 participants
@SupervisedThinking @facebook-github-bot @kloczek @senhuang42 @Cyan4973