Fixes to build with MSVC with /W4 #2664
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to 1.5.0 no longer builds with MSVC's warning level 4 due to "potentially uninitialized" local vars. It's a false positive, since each use is wrapped in a test for
if (dictMode == ZSTD_dictMatchState)
. The quick fix is to globally ignore the warnings, silencing these:It's not a comfortable warning to globally silence so the alternative would be to locally silence them (which is preferable to setting them to anything just to make the compiler happy).