Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pzstd: fix linking for static builds #2724

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 9, 2021

When trying to build statically, you get the following error:

[ 69%] Linking CXX executable pzstd
x86_64-unknown-linux-musl-ld: cannot find -llibzstd_shared
collect2: error: ld returned 1 exit status

This is to correct the build when shared libraries aren't available. (e.g. BUILD_SHARED=OFF)

With changes:

[100%] Linking CXX executable pzstd
[100%] Built target pzstd

@facebook-github-bot
Copy link

Hi @jonringer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jonringer
Copy link
Contributor Author

doing an else if may be more proper. But there's already an xor check on BUILD_SHARED and BUILD_STATIC

@jonringer
Copy link
Contributor Author

failing test seems to be from a fuzz test getting stalled

@terrelln terrelln merged commit 32cfe15 into facebook:dev Jul 28, 2021
@jonringer jonringer deleted the fix-pzstd-static-build branch July 29, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants