minor : change build macro to ZSTD_DECODER_INTERNAL_BUFFER #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just to make the topic more accessible for potential users.
terrelln
approved these changes
Oct 25, 2021
binhdvo
approved these changes
Oct 26, 2021
| #endif | ||
|
|
||
| #define ZSTD_LBMAX (128 << 10) |
There was a problem hiding this comment.
I can set a 64 byte minimum in a followup; is it sensible to add it here in the same manner?
There was a problem hiding this comment.
I'll do it in this PR.
also : introduced macro BOUNDED()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and reworded the doc to make the topic more accessible for potential users (focus on the visible symptoms).
One potential shortcoming is that I've not seen any minimum amount required for
ZSTD_LITBUFFEREXTRASIZEto work correctly. Now that's a value potentially controlled by the user, should there be such a minimum ? cc @binhdvo .