Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce function size in fast & dfast #2863

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Commits on Nov 16, 2021

  1. Reduce function size in fast & dfast

    Take the same approach as in PR facebook#2828 [0] to remove functions that force
    inline many function bodies and `switch`. Instead, create one function per
    "template" combination, and then switch between these functions. This
    allows the compiler to break the large function into many small
    functions, which generally helps codegen.
    
    Also, in the `extDict` modes when there is no ext-dict, call the top
    level function instead of the force inlined one, to save on code size.
    
    I'm specifically doing this because gcc on the parisc architecture doesn't
    handle the large function body well, and ends up using a lot of excess
    stack space. Outlining these functions fixes it.
    terrelln committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    802ea88 View commit details
    Browse the repository at this point in the history