Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #2891

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fix typos #2891

merged 2 commits into from
Dec 2, 2021

Conversation

supperPants
Copy link
Contributor

A spelling error was found, which could cause a memory leak.

@facebook-github-bot
Copy link

Hi @supperPants!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Cyan4973
Copy link
Contributor

Cyan4973 commented Dec 1, 2021

Nice catch @supperPants !

(note that we will need the CLA process to be completed to merge your contribution)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@supperPants
Copy link
Contributor Author

@Cyan4973 why were some checks not successful?

@Cyan4973
Copy link
Contributor

Cyan4973 commented Dec 2, 2021

The CLA was missing. I think it should be fine now. Let's the tests run again.

@terrelln terrelln merged commit 21e28f5 into facebook:dev Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants