Reject Irregular Dictionary Files #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixhandte
force-pushed
the
reject-irregular-dicts
branch
2 times, most recently
from
bd2e3ec
to
21035ff
Compare
terrelln
approved these changes
Dec 6, 2021
|
Looks good to me, except that the MinGW tests are failing. I wonder if the stat is failing? |
felixhandte
force-pushed
the
reject-irregular-dicts
branch
from
77a6d00
to
a0d0763
Compare
I hadn't seen facebook#2890, so I wrote my own version. I like this approach a little better, since it does an explicit check for a regular file, rather than passing a magic value. Addresses facebook#2874.
felixhandte
force-pushed
the
reject-irregular-dicts
branch
from
a0d0763
to
9985e10
Compare
Cyan4973
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't seen #2890, so I wrote my own version. I like this approach a little
better, since it does an explicit check for a regular file, rather than
passing a magic value.
Addresses #2874.