Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to specify memory limit for dictionary training #2925

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Allow user to specify memory limit for dictionary training #2925

merged 1 commit into from
Dec 15, 2021

Conversation

embg
Copy link
Contributor

@embg embg commented Dec 13, 2021

Follow-up to #2809.

@terrelln
Copy link
Contributor

Looks good to me, except for zstd.1! If you're having a hard time getting ronn-ng to work, you can always revert the zstd.1 changes, and we can regenerate it later.

@embg embg force-pushed the dict_training_sample_limit_size branch from 810a109 to 5cd8292 Compare December 14, 2021 19:26
@embg embg force-pushed the dict_training_sample_limit_size branch from 5cd8292 to 71c0c07 Compare December 14, 2021 19:29
@embg
Copy link
Contributor Author

embg commented Dec 14, 2021

Added a test which greps the stderr, and reverted zstd.1 changes (could not get ronn-ng working on Mac).

@embg embg merged commit c5f1e82 into facebook:dev Dec 15, 2021
@embg embg deleted the dict_training_sample_limit_size branch December 15, 2021 20:58
@Cyan4973 Cyan4973 mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@embg @terrelln @Cyan4973 @facebook-github-bot