Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect rowlog initialization #2931

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fixed incorrect rowlog initialization #2931

merged 1 commit into from
Dec 16, 2021

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Dec 15, 2021

the variable has only very limited usage,
being used only once at the beginning of the block, and only for prefetching,
hence, with no impact on final compression ratio, the error remained hidden.

the variable has only very limited usage,
being only used once at the beginning of the block for prefetching only,
hence the error had no impact on compression ratio.
Copy link
Contributor

@felixhandte felixhandte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the intended change is that the rowLog can also be 6?

I guess that's right, since looking at your previous diff there are specializations for 16, 32, and 64.

LGTM.

@Cyan4973
Copy link
Contributor Author

So the intended change is that the rowLog can also be 6?

I guess that's right, since looking at your previous diff there are specializations for 16, 32, and 64.

Yep, exactly.

@Cyan4973 Cyan4973 merged commit 5c96146 into dev Dec 16, 2021
@Cyan4973 Cyan4973 deleted the fix_rowlog branch January 13, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants