This repository has been archived by the owner on Jan 7, 2022. It is now read-only.
Delay generation and testing of docs on CircleCI (Fix #50) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By delaying the generation and testing of documentation on CircleCI until later in the job, it will not interrupt other tasks, such as unit tests.
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
calebmarchent
approved these changes
Oct 18, 2018
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 3, 2020
Summary: Typo in python shebang introduced by 0d19e27, probably by accident. Found while skimming the code. Pull Request resolved: facebook/openr#51 Reviewed By: steven1327 Differential Revision: D21865922 Pulled By: saifhhasan fbshipit-source-id: 5f2c2c2fac82078070920915812139f5fef1c7fe
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 18, 2020
…deps and use them in tests (#51) Summary: Pull Request resolved: facebook/sapling#51 This diff extends capabilities of CargoBuilder in getdeps so that individual manifests can be build even without workspaces. Thanks to that a build for edenapi/tools can be made and its artifacts can be used in mononoke integration tests. Reviewed By: StanislavGlebik Differential Revision: D23574887 fbshipit-source-id: 8a974a6b5235d36a44fe082aad55cd380d84dd09
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By delaying the generation and testing of documentation on CircleCI until later in the job, it will not interrupt other tasks, such as unit tests.
Fixes #50