Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Fix run_tests.sh when running locally #217

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

fabriziocucci
Copy link
Contributor

When running locally:

$ ./run_tests.sh
Re-running as root with sudo
./run_tests.sh: line 19: docker-compose: command not found

Hopefully this doesn't break the CI run...

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #217 (dc6c526) into master (f7a066a) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   61.81%   61.97%   +0.16%     
==========================================
  Files          88       88              
  Lines        4345     4345              
==========================================
+ Hits         2686     2693       +7     
+ Misses       1325     1318       -7     
  Partials      334      334              
Flag Coverage Δ
integration 56.82% <ø> (+0.16%) ⬆️
integration_storage 100.00% <ø> (ø)
unittests 49.74% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/teststeps/slowecho/slowecho.go 62.26% <0.00%> (+13.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a066a...dc6c526. Read the comment docs.

@rojer9-fb rojer9-fb self-requested a review January 25, 2021 16:48
Copy link
Contributor

@rojer9-fb rojer9-fb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@fabriziocucci fabriziocucci merged commit bb50ff0 into master Jan 25, 2021
@fabriziocucci fabriziocucci deleted the fc-fix-script-to-run-tests-locally branch January 25, 2021 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants