This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Background script logging + fix autorun launching scripts #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a logging directory at `/var/log/fbctf` - Redirect STDOUT and STDERR to an appropriate log file - When the log function is called in a web request, write to a generic web log file - Log when the game starts & ends - Log when the scripts are starting
The background script launching now checks where it's being run from, rather than just assuming that DOCUMENT_ROOT will always be available. This stops `autorun.php` from attempting to start `/scripts/*`, which doesn't exist.
This was referenced Mar 27, 2018
- Move starting & stopping to `Control`, and call those methods - Keeping autorun separate to avoid spamming the log files - Check whether a script is running before attempting to start it - Check actual process IDs, rather than hoping the database is accurate - Kill all instances of a script, rather than just the one in the DB - More logging to make debugging easier
|
so this fixed the base.php execution problem entirely and is this applied (commited) to repository? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/log/fbctf