Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Swift 2.0 #111

Merged
merged 1 commit into from
Sep 13, 2015
Merged

Swift 2.0 #111

merged 1 commit into from
Sep 13, 2015

Conversation

pietbrauer
Copy link
Contributor

🎆 Opening again

@nscoding
Copy link
Contributor

That's great @pietbrauer and updating scheme makes sense.

Can we squash the commits?

@nscoding
Copy link
Contributor

hmm now that I look at it again we can't have Swift 1.2 with Xcode 7 right? (So I can't really upgrade master to Xcode 7 without updating the Swift code.

Am I correct about this?

@pietbrauer
Copy link
Contributor Author

Yep, right. Thats why we have this swift-2.0 branch right? Once Xcode 7 is the newest Xcode, I would merge this (so on the 16th). I will rebase the commits in a second.

@pietbrauer
Copy link
Contributor Author

Squashed it

@pietbrauer pietbrauer changed the title [WIP] Swift 2.0 Swift 2.0 Sep 11, 2015
@nscoding
Copy link
Contributor

Awesome, one question before I merge, why is the red image different?

@pietbrauer
Copy link
Contributor Author

Thats a very good question. The test just failed on Xcode 7 it's not even a Swift test.

@nscoding
Copy link
Contributor

I tried with 8.4 and the test is passing, so I assume UIBlurEffect changed slightly with iOS9. I will proceed and merge this one, thanks @pietbrauer

nscoding pushed a commit that referenced this pull request Sep 13, 2015
Merge pull request #111 from nerdishbynature/swift-2.0
af151f8 
Swift 2.0
@nscoding nscoding merged commit af151f8 into facebookarchive:swift-2.0 Sep 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietbrauer @nscoding @facebook-github-bot