Implement Xcode 9 integration using XCTAttachment API #230
Conversation
| } | ||
|
|
||
| return nil; | ||
| } | ||
|
|
||
| - (void) addAttachementsWithErrors:(NSArray<NSError*>*)errors identifier:(NSString*)identifier { |
There was a problem hiding this comment.
s/Attachements/Attachments
| } | ||
|
|
||
| return nil; | ||
| } | ||
|
|
||
| - (void) addAttachementsWithErrors:(NSArray<NSError*>*)errors identifier:(NSString*)identifier { | ||
| #ifdef __IPHONE_11_0 |
There was a problem hiding this comment.
Will this work on macOS? FBSnapshotTestCase supports both.
| - (void) addAttachementsWithErrors:(NSArray<NSError*>*)errors identifier:(NSString*)identifier { | ||
| #ifdef __IPHONE_11_0 | ||
| if (self.recordMode) { | ||
| UIImage* image = [_snapshotController referenceImageForSelector:self.invocation.selector identifier:identifier error:nil]; |
There was a problem hiding this comment.
Most of the repo uses a different style for asterisk–alignment, I think you should match it.
|
@alanzeino Thanks for your response! Just updated my pull request. Also I think that you meant tvOS, not macOS? |
|
Yep, I meant tvOS. Sorry! Hopefully the project maintainer merges this one soon. |
|
Is there a plan to merge and release this? Would love to start using it now! |
|
Where are maintainers of this library? :( |
|
@fassko the project is in the facebookarchive. |
|
Hey there! We just moved the repo over here: https://github.com/uber/ios-snapshot-test-case Sorry to make you do this, but if you recreate the pull request we'll review it in the new repo. Thanks! |
|
@SiarheiFedartsou are you still keen to have it merged? I could do it for you, just need to figure how I do "commit together" to leave the credits in git history. I'm currently using own fork with this change applied and it's a tad inconvinient. |
|
@garnett yes, still want to merge it, but I’m procrastinating to recreate the PR :) will be very thankful if you will do it for me 👍 |
XCTest in Xcode 9 has a great new feature called attachments. It allows to add attachments to test results. So we can add our captured, reference and diff images to test if it was failed(see example on screenshot).
