-
Notifications
You must be signed in to change notification settings - Fork 96
Make typing introspection compatible with Python 3.7+ #37
Conversation
Had to switch Travis distro to Xenial in order to get 3.7 (see travis-ci/travis-ci#9815). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ylectric has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 65.45% 65.54% +0.09%
==========================================
Files 29 30 +1
Lines 1731 1753 +22
==========================================
+ Hits 1133 1149 +16
- Misses 598 604 +6
Continue to review full report at Codecov.
|
At last :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ylectric has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ylectric has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This PR makes Nubia compatible with Python 3.7+ by taking into account the changes introduced by PEP 560. The implementation was heavily inspired by ilevkivskyi/typing_inspect project.
Also run TravisCI tests against Python 3.7.
Closes #2.