Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Make typing introspection compatible with Python 3.7+ #37

Closed
wants to merge 2 commits into from
Closed

Make typing introspection compatible with Python 3.7+ #37

wants to merge 2 commits into from

Conversation

motohedgehog
Copy link

This PR makes Nubia compatible with Python 3.7+ by taking into account the changes introduced by PEP 560. The implementation was heavily inspired by ilevkivskyi/typing_inspect project.

Also run TravisCI tests against Python 3.7.

Closes #2.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 2, 2019
@motohedgehog
Copy link
Author

Had to switch Travis distro to Xenial in order to get 3.7 (see travis-ci/travis-ci#9815).

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylectric has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #37 into master will increase coverage by 0.09%.
The diff coverage is 88.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   65.45%   65.54%   +0.09%     
==========================================
  Files          29       30       +1     
  Lines        1731     1753      +22     
==========================================
+ Hits         1133     1149      +16     
- Misses        598      604       +6
Impacted Files Coverage Δ
nubia/internal/helpers.py 75.94% <ø> (-2.32%) ⬇️
nubia/internal/typing/__init__.py 93.65% <100%> (ø) ⬆️
nubia/internal/typing/argparse.py 85.52% <100%> (ø) ⬆️
nubia/internal/typing/inspect.py 84.84% <84.84%> (ø)
nubia/internal/typing/builder.py 87.82% <87.17%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0878b43...1b11e68. Read the comment docs.

@motohedgehog
Copy link
Author

At last :)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylectric has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylectric has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ylectric merged this pull request in 088e6f3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.7 compatibility
4 participants