Support fallback config when .pc file isn't available

Summary:
Not all distros (namely ubuntu) publish .pc files for their header packages.
This means that `pkg-config --libs <name>` fails, even though the headers are
avilable.

With this change, if `pkg-config` doesn't recognize the name, it can
potentially fallback to a hardcoded value. It isn't perfect, but gets ubuntu
builds to parity with fedora.

Reviewed By: bigfootjon

Differential Revision: D62789099

fbshipit-source-id: 815ef0f978516c1b5079cf75fad71fdf03f34de2

shim/third-party/brotli/BUCK

@@ -15,6 +15,7 @@ third_party_library(
     repo_package_names = {
         "fedora": "brotli-devel",
         "homebrew": "brotli",
+        "ubuntu": "libbrotli-dev",
     },
 )
 
@@ -24,5 +25,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "brotli-devel",
         "homebrew": "brotli",
+        "ubuntu": "libbrotli-dev",
     },
 )

shim/third-party/bzip2/BUCK

@@ -11,9 +11,13 @@ oncall("open_source")
 
 third_party_library(
     name = "bz2",
+    pkgconfig_fallback = struct(
+        linker_flags = ["-lbz2"],
+    ),
     pkgconfig_name = "bzip2",
     repo_package_names = {
         "fedora": "bzip2-devel",
         "homebrew": "bzip2",
+        "ubuntu": "libbz2-dev",
     },
 )

shim/third-party/double_conversion/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "double-conversion-devel",
         "homebrew": "double-conversion",
+        "ubuntu": "libdouble-conversion-dev",
     },
 )

shim/third-party/fast_float/BUCK

@@ -14,5 +14,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "fast_float-devel",
         "homebrew": "fast_float",
+        "ubuntu": "libfast-float-dev",
     },
 )

shim/third-party/fmt/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "fmt-devel",
         "homebrew": "fmt",
+        "ubuntu": "libfmt-dev",
     },
 )

shim/third-party/gflags/BUCK

@@ -14,6 +14,7 @@ third_party_library(
     pkgconfig_name = "gflags",
     repo_package_names = {
         "fedora": "gflags-devel",
-        "homebrew": "glags",
+        "homebrew": "gflags",
+        "ubuntu": "libgflags-dev",
     },
 )

shim/third-party/googletest/BUCK

@@ -15,6 +15,7 @@ third_party_library(
     repo_package_names = {
         "fedora": "gtest-devel",
         "homebrew": "googletest",
+        "ubuntu": "libgtest-dev",
     },
 )
 
@@ -24,6 +25,7 @@ third_party_library(
     repo_package_names = {
         "fedora": "gmock-devel",
         "homebrew": "googletest",
+        "ubuntu": "libgmock-dev",
     },
 )
 

shim/third-party/jemalloc/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "jemalloc-devel",
         "homebrew": "jemalloc",
+        "ubuntu": "libjemalloc-dev",
     },
 )

shim/third-party/libaio/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "libaio-devel",
         "homebrew": "libaio",
+        "ubuntu": "libaio-dev",
     },
 )

shim/third-party/libdwarf/BUCK

@@ -11,9 +11,13 @@ oncall("open_source")
 
 third_party_library(
     name = "dwarf",
+    pkgconfig_fallback = struct(
+        preprocessor_flags = ["-I/usr/include/libdwarf"],
+    ),
     pkgconfig_name = "libdwarf",
     repo_package_names = {
         "fedora": "libdwarf-devel",
         "homebrew": "libdwarf",
+        "ubuntu": "libdwarf-dev",
     },
 )

shim/third-party/liburing/BUCK

@@ -14,5 +14,6 @@ third_party_library(
     pkgconfig_name = "liburing",
     repo_package_names = {
         "fedora": "liburing-devel",
+        "ubuntu": "liburing-dev",
     },
 )

shim/third-party/lz4/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "lz4-devel",
         "homebrew": "lz4",
+        "ubuntu": "liblz4-dev",
     },
 )

shim/third-party/openssl/BUCK

@@ -15,6 +15,7 @@ third_party_library(
     repo_package_names = {
         "fedora": "openssl-devel",
         "homebrew": "openssl",
+        "ubuntu": "libssl-dev",
     },
 )
 

shim/third-party/python/BUCK

@@ -16,5 +16,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "python3-devel",
         "homebrew": "python3",
+        "ubuntu": "python3-dev",
     },
 )

shim/third-party/range-v3/BUCK

@@ -14,5 +14,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "range-v3-devel",
         "homebrew": "range-v3",
+        "ubuntu": "librange-v3-dev",
     },
 )

shim/third-party/snappy/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "snappy-devel",
         "homebrew": "snappy",
+        "ubuntu": "libsnappy-dev",
     },
 )

shim/third-party/third_party.bzl

@@ -15,7 +15,8 @@ def third_party_library(
         pkgconfig_name = None,
         repo_package_names = {},
         linker_flags = None,
-        homebrew_header_path = None):
+        homebrew_header_path = None,
+        pkgconfig_fallback = None):
     # Labels defined here are used to extract third-party libs so they can be installed
     labels = []
     for repo, package_name in repo_package_names.items():
@@ -31,6 +32,7 @@ def third_party_library(
             visibility = visibility if name == pkgconfig_name else [],
             labels = labels,
             deps = deps,
+            fallback = pkgconfig_fallback,
         )
         if name != pkgconfig_name:
             native.alias(

shim/third-party/xz/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "xz-devel",
         "homebrew": "liblzma",
+        "ubuntu": "liblz4-dev",
     },
 )

shim/third-party/zlib/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "zlib-devel",
         "homebrew": "zlib",
+        "ubuntu": "zlib1g",
     },
 )

shim/third-party/zstd/BUCK

@@ -15,5 +15,6 @@ third_party_library(
     repo_package_names = {
         "fedora": "libzstd-devel",
         "homebrew": "zstd",
+        "ubuntu": "libzstd-dev",
     },
 )